Optional outputrom #122
Closed
Optional outputrom #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
feel old yet? this PR was created closer to the initial release of asar than to today the ability to do this would be useful, but i don't like this approach, and the patch itself has bitrotted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the possibility to add an optional output name for the patched ROM:
asar patch.asm original.smc patched.smc
will copy original.smc to patched.smc before processing. If no output name is provided, the previous behavior is conserved, making the patch backwards compatible by patching the ROM in place.
Technically, it simply copies to ROMNAME to OUTNAME and then sets ROMNAME to OUTNAME afterwards.
The rationale for this patch is that when using a Versioning System or automated build processes for patching, you may want to conserve the original file while outputting to a build directory or similar.
While there is the small drawback of having to press enter once more when using the prompt to patch, the advantages of easier automation should outweigh this by far.